[PATCH] benchtests: Cleanup bench-malloc-thread

DJ Delorie dj@redhat.com
Fri Aug 1 19:20:57 GMT 2025


Wilco Dijkstra <Wilco.Dijkstra@arm.com> writes:
> Change duration to 3 seconds.  Add spaces before '('.
>
> OK for commit?

LGTM
Reviewed-by: DJ Delorie <dj@redhat.com>

>     <https://www.gnu.org/licenses/>.  */

Your mailer is replacing 0x20 space with 0xa0 space...  I suspect that's
why it failed to apply for the trybots.

> -# define TEST_FUNC(size) malloc(size)
> +# define TEST_FUNC(size) malloc (size)

Ok.

> -#define BENCHMARK_DURATION     10
> +#define BENCHMARK_DURATION     3

Ok.  This may add some variability to the output, though.

> -         pthread_create(&threads[i], NULL, benchmark_thread, &args[i]);
> +         pthread_create (&threads[i], NULL, benchmark_thread, &args[i]);

Ok.

> -         pthread_join(threads[i], NULL);
> +         pthread_join (threads[i], NULL);

Ok.

> -static void usage(const char *name)
> +static void usage (const char *name)

Ok.

> -      ret = strtol(argv[1], NULL, 10);
> +      ret = strtol (argv[1], NULL, 10);

Ok.

> -       usage(argv[0]);
> +       usage (argv[0]);

Ok.

> -    usage(argv[0]);
> +    usage (argv[0]);

Ok.

> -  getrusage(RUSAGE_SELF, &usage);
> +  getrusage (RUSAGE_SELF, &usage);

Ok.



More information about the Libc-alpha mailing list