Creating a tag to track partial reviews: "Consulted:"
Carlos O'Donell
carlos@redhat.com
Mon Apr 28 12:39:27 GMT 2025
Community,
Joseph Myers raised a good point that someone might review all but the
final version of a series, or patch, but the final approval and
Reviewed-by: is given by someone else, and thus we don't end up thanking
someone who might have done the bulk of the review work that makes the
final RB easy.
In the vein of "Reviewed-by:" I would like to add a "Consulted:" tag to
indicate that this developer was consulted in the creation of the patch
and involved in review of some aspect of the work, but it did not cross
the line into being completely acceptable.
This is different from "Acked-by:" which is acceptance of inclusion for
a subsystem e.g. like "Reviewed-by:" but only for a part of the patch,
and "CC:" since this is a passive "this person was notified."
The goal of "Consulted:" is to give credit to partial reviews.
The description looks like this:
~~~
Consultant’s statement of oversight
By offering my Consulted: tag, I state that:
* I have carried out at least a minimal amount of technical review of this
patch to evaluate its appropriateness and readiness for inclusion.
* Any problems, concerns, or questions relating to the patch have been
communicated back to the submitter.
* I am NOT yet satisfied with the submitter’s response to my comments, or
the technical content of the patch.
* I would like to be consulted in future discussions about the patch, but
I recognize that the patch may move forward without my explicit approval
and follow the normative development rules of the project.
A Consulted tag is a statement of opinion that the patch is not yet an
appropriate modification of the project. Any interested reviewer
(who has done the work) can offer a Consulted tag for a patch. This tag
serves to give credit to partial reviews and to inform maintainers of the
degree of review which has been done on the patch. Consulted tags, when
supplied by reviewers known to understand the subject area and to perform
thorough reviews, will normally increase the likelihood of your patch
getting into the project.
If a reviewer completes a review then they should send a Reviewed-by tag
which supersedes a Consulted tag.
~~~
Thoughts?
--
Cheers,
Carlos.
More information about the Libc-alpha
mailing list