[PATCH v2] benchtest: Correct shell script related to bench-malloc-thread
Florian Weimer
fweimer@redhat.com
Fri Apr 25 11:56:52 GMT 2025
* Cupertino Miranda:
> Hi everyone,
>
> This is v2 for the patch following Florians review.
> Thank you for the suggestion.
>
> Cheers,
> Cupertino
>
> This patch changes the shell script that selects which arguments are used
> for the execution of bench-malloc-thread.
> The problem seems to have been introduced in commit:
>
> commit 2d6427a63cad8056ba6bcaaaa8df21977c8dde3d
> Author: Wangyang Guo <wangyang.guo@intel.com>
> Date: Fri Nov 29 16:05:35 2024 +0800
> benchtests: Add calloc test
>
> With current condition, the following error "/bin/sh: 3: [[: not found"
> occurs when executing `make bench BENCHSET="malloc-thread"` and the else
> path is taken, using incorrect arguments for bench test execution.
>
> Error is reproducible in Debian based distros.
> ---
> benchtests/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/benchtests/Makefile b/benchtests/Makefile
> index cccee62eb0..74142da326 100644
> --- a/benchtests/Makefile
> +++ b/benchtests/Makefile
> @@ -493,7 +493,7 @@ bench-set: $(binaries-benchset)
> bench-malloc: $(binaries-bench-malloc)
> for run in $^; do \
> echo "$${run}"; \
> - if [[ `basename $${run}` =~ bench-[cm]alloc-thread ]]; then \
> + if basename $${run} | grep -q "bench-[cm]alloc-thread"; then \
> for thr in 1 8 16 32; do \
> echo "Running $${run} $${thr}"; \
> $(run-bench) $${thr} > $${run}-$${thr}.out; \
This version looks okay to me.
Reviewed-by: Florian Weimer <fweimer@redhat.com>
Thanks,
Florian
More information about the Libc-alpha
mailing list