[PATCH v4 5/5] aarch64: Add SFrame support for aarch64 architecture

[Claudiu Zissulescu-Ianculescu]

>> +/* This code is inspired from libgcc's MD_FALLBACK_FRAME_STATE_FOR
>> +   implementation.  See libgcc/config/aarch64/gnu-unwind.h  */
> 
> Surely not, as for aarch64 (unlike for x86), it's a TODO ;)
> 
> You mean libgcc/config/aarch64/linux-unwind.h.


Yes, that is it!

>> +#define SP_REGNUM 31
>> +#define LR_REGNUM 29
> 
> What's the purpose of these other two defines? I'm not against them
> being here as documentation (and it's up to the aarch64 maintainers),
> but curious. A comment may be nice if it is just for documentation.
> 

I have remove them, I thought I'll use them but actually was not required.


Thank you for your feedback,
Claudiu