[PATCH] tst-scanf-format-real: don't crash on nan()
Maciej W. Rozycki
macro@redhat.com
Thu Apr 10 15:31:15 GMT 2025
On Thu, 10 Apr 2025, Carlos O'Donell wrote:
> > > May you please post a v2 that accounts for this correctly to avoid this
> > > becoming a problem in the future?
> >
> > It cannot.
> >
>
> I understand that position. Particularly since the existing code suffers
> no ill effects.
>
> Will you be posting a v2 with the requested changes?
Can we please hold on with this yet? This is a fix for an unhandled data
input format, which doesn't affect any actual input present in our tests.
As such, there's no need to rush with an update here; input data formats
supported here are a subset of what ISO C has defined (although I agree
code mustn't crash on rubbish input but instead handle it gracefully).
My understanding of the issue has been that on M68K "nan" and "nan()"
produce different results as inputs to `strtod', etc. I've got a fix in
the queue and for that we'll need a corresponding update to handle "nan"
and "nan()" reference input accordingly in the tests. Naturally that'll
require both to be handled correctly.
Maciej
More information about the Libc-alpha
mailing list