[PATCH v3 12/29] mips: Add <bits/pagesize.h>

Florian Weimer fweimer@redhat.com
Mon Sep 30 11:43:51 GMT 2024


* Maciej W. Rozycki:

> On Mon, 30 Sep 2024, Florian Weimer wrote:
>
>> > "[...]  To avoid the overhead and loss of test coverage by accepting
>> > gaps everywhere, this series teaches glibc the possible range of page
>> > sizes for each supported architecture."
>> >
>> > (or indeed BZ referred) which of the alternatives I quote above is right, 
>> > i.e. I find "supported architecture" ambiguous here -- is it an OS port or 
>> > a CPU architecture?
>> 
>> It's the combination of both.
>
>  So I guess it should go into sysdeps/unix/sysv/linux/mips/bits/pagesize.h 
> then, shouldn't it?  Then it'll fail compilation if someone tries to build 
> glibc for a non-Linux MIPS platform, bringing their attention to the need 
> to add these bits to their port rather than silently using Linux settings 
> and possibly causing tough to track down troubles later on.  Am I missing 
> anything here?

I think this makes sense for MIPS.  Are there any other glibc targets
with a software-defined TLB and where page sizes are similarly
kernel-defined?

Thanks,
Florian



More information about the Libc-alpha mailing list