[PATCH v3 02/29] Prepare for the addition of the <sys/pagesize.h> header
Florian Weimer
fweimer@redhat.com
Sun Sep 29 19:47:00 GMT 2024
* Paul Eggert:
> On 2024-09-29 08:49, Florian Weimer wrote:
>> +#define PAGE_SIZE_MIN (1UL << __GLIBC_PAGE_SHIFT_MIN)
>> +#define PAGE_SIZE_MAX (1UL << __GLIBC_PAGE_SHIFT_MAX)
>
> Shouldn't these have the same type as sysconf (_SC_PAGESIZE)? It seems
> odd to introduce yet another type for page sizes.
Well, getpagesize returns an int, so there's not much consistency to be
had here.
I can turn it into 1L if you prefer that, but byte counts are generally
measured in size_t …
Thanks,
Florian
More information about the Libc-alpha
mailing list