[PATCH v2] arc: Cleanup arcbe

Florian Weimer fweimer@redhat.com
Mon Sep 23 12:47:14 GMT 2024


* Sam James:

>> -# For big endian ABI, generate a symbol for selecting right dynamic linker
>> +# ARC big endian ABI is no longer supported.
>
> Why do we need to keep this configure check? Florian's patch removed its
> use but not the check itself.

I should have updated the comment:

 # For big endian ABI, generate a symbol for selecting right dynamic linker
 AC_CACHE_CHECK([for big endian],
   [libc_cv_arc_be],
   [AC_EGREP_CPP(yes,[#ifdef __BIG_ENDIAN__
                       yes
                      #endif
   ], libc_cv_arc_be=yes, libc_cv_arc_be=no)])
 if test $libc_cv_arc_be = yes; then
-  # For shlib-versions.
-  AC_DEFINE(HAVE_ARC_BE)
-  LIBC_CONFIG_VAR([default-abi], [arcbe])
-else
-  LIBC_CONFIG_VAR([default-abi], [arcle])
+  AC_MSG_ERROR([big-endian not supported])
 fi
+LIBC_CONFIG_VAR([default-abi], [arcle])

I think it's valuable to fail here instead of producing an incorrect
ABI.

Thanks,
Florian



More information about the Libc-alpha mailing list