[PATCH v2] Add another test for fclose on an unopened file

Aaron Merey amerey@redhat.com
Fri Sep 20 14:40:38 GMT 2024


On Fri, Sep 20, 2024 at 10:21 AM Carlos O'Donell <carlos@redhat.com> wrote:
>
> On 9/19/24 8:37 PM, Aaron Merey wrote:
> > Add new file libio/tst-fclose-unopened2.c that tests whether fclose on an
> > unopened file returns EOF.
> >
> > This test differs from tst-fclose-unopened.c by ensuring the file's buffer
> > is allocated prior to double-fclose.  A comment in tst-fclose-unopened.c
> > now clarifies that it is testing a file with an unallocated buffer.
>
> LGTM. Please include the Reviewed-by: tag in your commit message.
>
> Please consider adding the comment to the magic 6-byte buffer, you can do that without
> needing another round of review if that's the only change you make. You can keep my
> Reviewed-by: tag is that's the only change you make.
>
> Reviewed-by: Carlos O'Donell <carlos@redhat.com>

Thanks Carlos, merged as commit 35dc62de3d5d.

Aaron



More information about the Libc-alpha mailing list