[PATCH] debug: Fix read error handling in pcprofiledump

Andreas Schwab schwab@suse.de
Mon Sep 9 11:09:50 GMT 2024


On Sep 09 2024, Florian Weimer wrote:

> +	  if (!read_exactly (fd, ptrs, sizeof (ptrs),
> +			    _("cannot read pointer pair"), true))

I think it is better to mark the message with N_ and call gettext only
when the error actually happens in read_exactly.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."


More information about the Libc-alpha mailing list