[PATCH] powerpc64le: The ABI requires stack frames to be 16-byte

Sachin Monga smonga@linux.ibm.com
Mon Oct 28 06:20:00 GMT 2024


> This was built and regression tested, correct?  Proper patch submissions
> should state where and how the patch was tested and that no regressions
> were seen.

Yes. It was built and tested for regression with no errors. Generally, I 
send patch through "git send-email" so not sure if we use "--annotate" 
for this or simply edit the patch below commit message's ---

Will check.

> That said, the patch LGTM, but the subject line looks truncated as it
> should say "aligned" at the end...and that would be better as the git
> log entry.
>
> I'll fix that up along with the Subject line and merge it once I've
> heard from you that you did build and test the patch with no errors.
I am re-sharing it here as attachment.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://sourceware.org/pipermail/libc-alpha/attachments/20241028/5040fa42/attachment.htm>
-------------- next part --------------
From 2c8698feb66e947af7d326c1dde294f97e36ddf2 Mon Sep 17 00:00:00 2001
From: Sachin Monga <sachin.monga@ibm.com>
Date: Fri, 25 Oct 2024 01:44:46 -0500
Subject: [PATCH] powerpc64le: Adhering to stack alignment ABI requirement.

The ABI requires stack frames to be 16-byte aligned.

Signed-off-by: Sachin Monga <sachin.monga@ibm.com>
---
 sysdeps/powerpc/powerpc64/le/power9/strncpy.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sysdeps/powerpc/powerpc64/le/power9/strncpy.S b/sysdeps/powerpc/powerpc64/le/power9/strncpy.S
index eccb2ffbb0..58139ad9e8 100644
--- a/sysdeps/powerpc/powerpc64/le/power9/strncpy.S
+++ b/sysdeps/powerpc/powerpc64/le/power9/strncpy.S
@@ -43,7 +43,7 @@
 # endif
 #endif
 
-#define FRAMESIZE (FRAME_MIN_SIZE+8)
+#define FRAMESIZE (FRAME_MIN_SIZE+16)
 
 /* Implements the function
 
-- 
2.47.0



More information about the Libc-alpha mailing list