[PATCH v2] error: Don't call va_end twice [BZ #32233].

[Sam James]

Collin Funk <collin.funk1@gmail.com> writes:

> Hi Sam,
>
> Makes sense, was a bit lazy of me. This should be better.
>
> -- 8< --
>
> Sync to Gnulib commit ba9136b7646ef9e01ffad3ddcf232002354531d0
>

Thank you!

> * misc/error.c (error_tail): Remove va_end call.
> (__error_internal): Use the '%u' conversion specifier instead of '%d'
> for 'line_number' which is an unsigned int.
>
> The following changes are only applicable to Gnulib:
>
> * misc/error.c: Use #include <error.h> instead of #include "error.h" to
> silence Clang's -Winclude-next-absolute-path.
> (__error_internal, __error_at_line_internal, error_tail): Define to
> Gnulib symbols.
> [_WIN32 && !__CYGWIN__]: Include io.h for Windows function declarations.
> (strerror_r): Use a C23 compatible declaration.
> (program_name): Define to getprogname.
> (verror, verror_at_line) [GNULIB_defined_verror]: Define symbols.
>
> Signed-off-by: Collin Funk <collin.funk1@gmail.com>
> ---
>  misc/error.c | 89 ++++++++++++++++++++++++++++++----------------------
>  1 file changed, 52 insertions(+), 37 deletions(-)

Reviewed-by: Sam James <sam@gentoo.org>

> [...]

thanks,
sam
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 377 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/libc-alpha/attachments/20241007/58ef37e6/attachment.sig>