[PATCH v8] linux: Add support for getrandom vDSO
Adhemerval Zanella Netto
adhemerval.zanella@linaro.org
Wed Oct 2 14:05:37 GMT 2024
On 02/10/24 10:58, Jason A. Donenfeld wrote:
> On Wed, Oct 02, 2024 at 10:31:08AM -0300, Adhemerval Zanella Netto wrote:
>>
>>
>> On 02/10/24 09:47, Cristian Rodríguez wrote:
>>>
>>>
>>> On Mon, Sep 30, 2024 at 2:00 PM Jason A. Donenfeld <Jason@zx2c4.com <mailto:Jason@zx2c4.com>> wrote:
>>>
>>> This v8 is looking pretty okay to me.
>>>
>>> Florian, what do you say we merge this? We've got a long cycle ahead of
>>> us for 2.40 too, so as things come up we'll be able to fix them.
>>>
>>>
>>> Yeah, it is fine.. I have perhaps one minor request if possible to do sanely.. an internal-only global flag that means "getrandom is fast" (the vdso version works here)
>>> So one can replace most internal uses of random_bits() , HP_TIMING fast_jitter or similar internal interfaces..
>>
>> That's not a bad idea, and it was on my backlog. It should a matter to export
>> 'state_size', or a function that check it size. I will check in which place
>> we can use getrandom instead.
>
> It indeed is a good idea. Maybe let's do that in a follow up commit, so
> that this one can actually land? I don't think we need a v9, and we're
> basically just waiting on Florian's ack now.
Yes, I do not intend to factor this in this version. The internal glibc usage
should be orthogonal and thus in a different patch.
More information about the Libc-alpha
mailing list