[PATCH v3] Add test of ELF hash collisions
Florian Weimer
fweimer@redhat.com
Fri Nov 29 13:57:56 GMT 2024
* Joseph Myers:
> On Mon, 28 Oct 2024, Florian Weimer wrote:
>
>> I think that's an area where the symbol version hash implementation has
>> a problems (bug 29190).
>
> This third patch version also adds tests of symbol version hash
> collisions - but only tests hash values 1 and 2 for symbol versions,
> not hash value 0, given that known issue with symbol versions hashing
> to 0.
Understood.
> Add test of ELF hash collisions
>
> Add tests that the dynamic linker works correctly with symbol names
> involving hash collisions, for both choices of hash style (and
> --hash-style=both as well). I note that there weren't actually any
> previous tests using --hash-style (so tests would only cover the
> default linker configuration in that regard). Also test symbol
> versions involving hash collisions.
>
> Tested for x86_64.
>
> ---
>
> Changed in v2: also test collisions various specific values of the
> hashes and a case with more than one shared object involved.
>
> Changed in v3: added test of symbol version hash collisions.
This version looks okay to me.
Reviewed-by: Florian Weimer <fweimer@redhat.com>
Thanks,
Florian
More information about the Libc-alpha
mailing list