[PATCH] Remove unused dl-procinfo.h

Stefan Liebler stli@linux.ibm.com
Thu Nov 28 13:53:19 GMT 2024


On 26.11.24 18:06, Adhemerval Zanella Netto wrote:
> 
> 
> On 26/11/24 13:03, Peter Bergner wrote:
>> On 11/26/24 9:44 AM, Stefan Liebler wrote:
>>> If the intention is really to not print AT_HWCAP strings anymore, then
>>> please also remove dl_s390_cap_flags in sysdeps/s390/dl-procinfo-s390.c.
>>> I think _DL_HWCAP_COUNT can then also be removed (not only on s390).
>>
>> I hope that's not the intention, unless there is a replacement for
>> "LD_SHOW_AUXV=1 /bin/true" I don't know about.  I do this all the
>> time.
>>
>> Peter
> 
> We discussed this briefly some time ago [1], and my take was this debug
> information is not a hard requirement.  And it is not really consistent
> over architectures where aarch64 defines dl_aarch64_cap_flags, but does not
> add the debug print hook.
> 
> If you think we should really keep it, maybe then keep the removal of
> the ones that are either empty (alpha, csky) or unused (aarch64, x86) along
> with _dl_hwcap_string (which is unused since the glibc-hwcap), and
> them move dl_<arch>_cap_flags out of _rtld_global and make it local 
> to _dl_procinfo.
> 
> [1] https://sourceware.org/pipermail/libc-alpha/2024-November/161275.html

For s390, we've discussed it internally and we are fine with removing
the names. Thus if you do so, as already mentioned please also remove
dl_s390_cap_flags in sysdeps/s390/dl-procinfo-s390.c and the
_DL_HWCAP_COUNT definition.

Bye,
Stefan


More information about the Libc-alpha mailing list