[PATCH 00/13] htl: move pthread_attr_* into libc

Samuel Thibault samuel.thibault@aquilenet.fr
Tue Nov 19 00:59:18 GMT 2024


Hello,

gfleury, le lun. 18 nov. 2024 13:21:32 +0200, a ecrit:
> Hello, I've created a patch for the series that relocates pthread_attr* to libc.

Applied with some fixes, thanks!

> I would appreciate your review, especially regarding the x86_64 part,
> as I'm uncertain sometimes about adding a new symbol there.

It was alright the way you did it.

Please however take care of the Makefile ordering which needs to be
strictly alphabetic. Also, 2.41 is between 2.4 and 2.5 :)

Also, make the elf/check-localplt.out check to verify whether you need a
hidden def.

Samuel

> gfleury (13):
>   htl: move pthread_attr_destroy into libc.
>   htl: move __pthread_default_attr into libc
>   htl move pthread_attr_getguardsize into libc.
>   htl move pthread_attr_getscope into libc.
>   htl move pthread_attr_getstacksize into libc.
>   htl: move pthread_attr_getstackaddr into libc.
>   htl: move pthread_attr_getstack  into libc.
>   htl: move pthread_attr_setstacksize into libc.
>   htl: move pthread_attr_setstackaddr into libc.
>   htl: move pthread_attr_setscope into libc.
>   htl: move pthread_attr_setschedparam into libc.
>   htl: move pthread_attr_setguardsize into libc.
>   htl: move pthread_attr_init into libc.
> 
>  htl/Makefile                                | 28 +++++++-------
>  htl/Versions                                | 42 ++++++++++++++++-----
>  htl/forward.c                               | 14 -------
>  htl/pt-initialize.c                         |  5 ---
>  htl/pt-internal.h                           |  1 +
>  sysdeps/htl/pt-attr-destroy.c               |  7 +++-
>  sysdeps/htl/pt-attr-getguardsize.c          |  8 +++-
>  sysdeps/htl/pt-attr-getscope.c              |  6 ++-
>  sysdeps/htl/pt-attr-getstack.c              |  7 +++-
>  sysdeps/htl/pt-attr-getstackaddr.c          |  7 +++-
>  sysdeps/htl/pt-attr-getstacksize.c          |  7 +++-
>  sysdeps/htl/pt-attr-init.c                  |  8 +++-
>  sysdeps/htl/pt-attr-setguardsize.c          |  8 +++-
>  sysdeps/htl/pt-attr-setschedparam.c         |  7 +++-
>  sysdeps/htl/pt-attr-setscope.c              |  6 ++-
>  sysdeps/htl/pt-attr-setstack.c              |  8 +++-
>  sysdeps/htl/pt-attr-setstackaddr.c          |  7 +++-
>  sysdeps/htl/pt-attr-setstacksize.c          |  7 +++-
>  sysdeps/htl/pt-attr.c                       |  1 +
>  sysdeps/htl/pthread-functions.h             | 11 ------
>  sysdeps/htl/pthreadP.h                      |  2 +
>  sysdeps/mach/hurd/i386/libc.abilist         | 22 +++++++++++
>  sysdeps/mach/hurd/i386/libpthread.abilist   | 13 -------
>  sysdeps/mach/hurd/x86_64/libc.abilist       | 16 ++++++++
>  sysdeps/mach/hurd/x86_64/libpthread.abilist | 13 -------
>  25 files changed, 166 insertions(+), 95 deletions(-)
> 
> -- 
> 2.39.5
> 

-- 
Samuel
 > Voici mon problème, j'ai deux PCs relies par des cartes ethernet, 
 > configures avec le protocole PPP.
 -+- Romain in Guide du linuxien pervers - "Ils sont fous ces romains !" -+-


More information about the Libc-alpha mailing list