[PATCH v1] x86/string: Use `movsl` instead of `movsd` in strncpy/strncat [BZ #32344]

H.J. Lu hjl.tools@gmail.com
Tue Nov 12 23:12:33 GMT 2024


On Wed, Nov 13, 2024 at 7:04 AM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
>
> `ld`, starting at 2.40, emits a warning when using `movsd`. There is
> no change to the actual code produced.
> ---
>  sysdeps/x86_64/multiarch/strncpy-evex.S | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sysdeps/x86_64/multiarch/strncpy-evex.S b/sysdeps/x86_64/multiarch/strncpy-evex.S
> index d4053bb5f0..9b2629a5a4 100644
> --- a/sysdeps/x86_64/multiarch/strncpy-evex.S
> +++ b/sysdeps/x86_64/multiarch/strncpy-evex.S
> @@ -43,7 +43,7 @@
>  #  define VPTEST       vptestmd
>  #  define CHAR_SIZE    4
>
> -#  define REP_MOVS     rep movsd
> +#  define REP_MOVS     rep movsl
>  #  define REP_STOS     rep stosl
>
>  #  define USE_WIDE_CHAR
> --
> 2.43.0
>

LGTM.

Reviewed-by: H.J. Lu <hjl.tools@gmail.com>

Thanks.

-- 
H.J.


More information about the Libc-alpha mailing list