[PATCH v10] linux: Add support for getrandom vDSO

Florian Weimer fweimer@redhat.com
Mon Nov 11 14:03:32 GMT 2024


* Jason A. Donenfeld:

> On Tue, Nov 05, 2024 at 04:58:13PM +0100, Florian Weimer wrote:
>> * Adhemerval Zanella:
>> 
>> > diff --git a/NEWS b/NEWS
>> > index 2fe0396b2d..0d3107ed68 100644
>> > --- a/NEWS
>> > +++ b/NEWS
>> > @@ -42,7 +42,9 @@ Deprecated and removed features, and other changes affecting compatibility:
>> >  
>> >  Changes to build and runtime requirements:
>> >  
>> > -  [Add changes to build and runtime requirements here]
>> > +* On recent Linux kernels with vDSO getrandom support, getrandom does not
>> > +  act as a shall occur cancellation point.  It this case, the getrandom may
>> > +  not issue any syscall, nor trigger a deferred cancellation event.
>> 
>> Maybe a native speaker could make some suggestions here?  I would at
>> least add quotation marks around “shall occur”, to make the attributive
>> use clearer, or add a hyphen.
>
> """
> On recent Linux kernels with vDSO getrandom support, getrandom does not
> act as a "shall occur" cancellation point, in which case it might
> not issue a syscall or trigger a deferred cancellation event.
> """

Looks good to me, thanks.

Florian



More information about the Libc-alpha mailing list