[PATCH v1] x86/string: Use `movsl` instead of `movsd` [BZ #32344]

H.J. Lu hjl.tools@gmail.com
Fri Nov 8 22:15:02 GMT 2024


On Sat, Nov 9, 2024 at 3:18 AM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
>
> `ld`, starting at 2.40, emits a warning when using `movsd`. There is
> no change to the actual code produced.
> ---
>  sysdeps/x86_64/multiarch/strcpy-evex.S | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sysdeps/x86_64/multiarch/strcpy-evex.S b/sysdeps/x86_64/multiarch/strcpy-evex.S
> index 4f5bd3ba55..be1d65453c 100644
> --- a/sysdeps/x86_64/multiarch/strcpy-evex.S
> +++ b/sysdeps/x86_64/multiarch/strcpy-evex.S
> @@ -45,7 +45,7 @@
>  #  define VPCMPEQ      vpcmpeqd
>  #  define CHAR_SIZE    4
>
> -#  define REP_MOVS     rep movsd
> +#  define REP_MOVS     rep movsl
>
>  #  define USE_WIDE_CHAR
>  # else
> --
> 2.34.1
>

LGTM.

Reviewed-by: H.J. Lu <hjl.tools@gmail.com>

Thanks.

-- 
H.J.


More information about the Libc-alpha mailing list