[PATCH] LoongArch: Add soft floating-point fe* function implementations.

Joseph Myers josmyers@redhat.com
Wed Mar 27 17:10:49 GMT 2024


On Wed, 27 Mar 2024, caiyinyu wrote:

> Yes, this patch does make sense in both libc and libm and it can be proved by
> the following glibc tests:

Please explain more how it works.

> All the functions Implemented in this patch are exported from libm.so the same
> as powerpc nofpu.

I'm talking about functions such as __adddf3 (which would need to be 
exported from libc, not libm, to provide exceptions / rounding modes 
support for software floating point).  I don't see them in any Versions 
file for LoongArch.

Furthermore, this patch isn't changing sfp-machine.h for LoongArch, which 
uses fpu_control.h to get rounding mode / exceptions state, and it isn't 
changing how fpu_control.h uses constant 0 for that state in the 
soft-float case.  So I don't see how it would produce *working* exceptions 
/ rounding modes support for software floating-point arithmetic.

-- 
Joseph S. Myers
josmyers@redhat.com



More information about the Libc-alpha mailing list