[PATCH 00/15] Fix some libm static issues
Adhemerval Zanella
adhemerval.zanella@linaro.org
Wed Mar 27 16:45:12 GMT 2024
Some recent math optimizations removed some symbols from the static
build and due to the limited static build check, along with
--disable-shared being broken for some time [1]; this issue has slipped
some releases.
Although the fix is straightforward, I added an extra framework to
enable static build for select math libraries using the generic type
framework (which autogenerated the tests for all supported types using
the C template files). I have not enabled it for all tests due to the
required extra size constraint, maybe a future
---enable-static-math-tests configure option could improve test
coverage.
As an experiment, I enabled static build for all autogenerated math
tests. This has uncovered some extra missing symbols on some ABIs, along
with some issues with implementation used on static for some ABIs.
I tested this patchset on x86_64, i686, armhf, aarch64, and powerpc64le.
The powerpc64le shows some issues with the static linking, due to the
newly enabled tests (using gcc 13.1):
FAIL: math/test-float128-exp10-static
FAIL: math/test-float128-y1-static
FAIL: math/test-float64x-exp10-static
FAIL: math/test-float64x-y1-static
FAIL: math/test-ibm128-acos-static
FAIL: math/test-ibm128-copysign-static
FAIL: math/test-ibm128-exp10-static
FAIL: math/test-ibm128-fmod-static
FAIL: math/test-ibm128-frexp-static
FAIL: math/test-ibm128-log10-static
FAIL: math/test-ibm128-log2-static
FAIL: math/test-ibm128-modf-static
FAIL: math/test-ibm128-y0-static
FAIL: math/test-ibm128-y1-static
I have not analyzed what is happening, but it might be due to the
'-mabi=ibmlongdouble' along with how libgcc.a was built (I saw some
issues on GCC bugzilla). One option could be XFAIL for now.
[1] https://sourceware.org/bugzilla/show_bug.cgi?id=20845
Adhemerval Zanella (15):
math: Add support for auto static math tests
math: Fix i386 and m68k fmod/fmodf on static build (BZ 31488)
i386: Use generic fmod
i386: Use generic fmodf
math: Fix i386 and m68k exp10 on static build
i386: Use generic exp10
math: Fix isnanf128 static build
math: Provided copysignf128 for static libm on alpha, s390, and
sparcv9
math: Provide frexpf128 for static libm on alpha, s390, and sparcv9
math: Provide modf128 for static libm on alpha, s390, and sparcv9
math: Fix acos template for arguments greater than 1
math: Fix log10 template for inputs less than 0
math: Fix log2 template for inputs less than 0
math: Fix y0 template for arguments less/equal than 0
math: Fix y1 template for arguments less/equal than 0
math/Makefile | 116 +++++++++++++++++++-
math/test-double-static.h | 1 +
math/test-float-static.h | 1 +
math/test-float128-static.h | 1 +
math/test-float32-static.h | 1 +
math/test-float32x-static.h | 1 +
math/test-float64-static.h | 1 +
math/test-float64x-static.h | 1 +
math/test-ibm128-static.h | 1 +
math/test-ldouble-static.h | 1 +
math/w_acos_template.c | 9 +-
math/w_j0_template.c | 16 ++-
math/w_j1_template.c | 16 ++-
math/w_log10_template.c | 16 ++-
math/w_log2_template.c | 16 ++-
sysdeps/i386/fpu/Versions | 5 +
sysdeps/i386/fpu/e_exp10.S | 51 ---------
sysdeps/i386/fpu/e_exp10.c | 2 +
sysdeps/i386/fpu/e_exp_data.c | 1 -
sysdeps/i386/fpu/e_fmod.S | 18 ---
sysdeps/i386/fpu/e_fmod.c | 2 +
sysdeps/i386/fpu/e_fmodf.S | 18 ---
sysdeps/i386/fpu/e_fmodf.c | 2 +
sysdeps/i386/fpu/math_err.c | 1 -
sysdeps/i386/fpu/w_exp10_compat.c | 3 -
sysdeps/i386/fpu/w_fmod_compat.c | 14 ---
sysdeps/i386/fpu/w_fmodf_compat.c | 14 ---
sysdeps/ieee754/dbl-64/e_exp10.c | 7 +-
sysdeps/ieee754/dbl-64/e_fmod.c | 5 +-
sysdeps/ieee754/float128/float128_private.h | 2 +-
sysdeps/ieee754/float128/s_isnanf128.c | 4 +
sysdeps/ieee754/flt-32/e_fmodf.c | 5 +-
sysdeps/ieee754/ldbl-64-128/s_copysignl.c | 4 +-
sysdeps/ieee754/ldbl-64-128/s_frexpl.c | 4 +-
sysdeps/ieee754/ldbl-64-128/s_modfl.c | 4 +-
sysdeps/ieee754/ldbl-opt/s_ldexpl.c | 4 +-
sysdeps/m68k/m680x0/fpu/w_exp10_compat.c | 9 +-
sysdeps/m68k/m680x0/fpu/w_fmod_compat.c | 5 +-
sysdeps/m68k/m680x0/fpu/w_fmodf_compat.c | 7 +-
sysdeps/mach/hurd/i386/libm.abilist | 3 +
sysdeps/unix/sysv/linux/i386/libm.abilist | 3 +
41 files changed, 235 insertions(+), 160 deletions(-)
create mode 100644 math/test-double-static.h
create mode 100644 math/test-float-static.h
create mode 100644 math/test-float128-static.h
create mode 100644 math/test-float32-static.h
create mode 100644 math/test-float32x-static.h
create mode 100644 math/test-float64-static.h
create mode 100644 math/test-float64x-static.h
create mode 100644 math/test-ibm128-static.h
create mode 100644 math/test-ldouble-static.h
delete mode 100644 sysdeps/i386/fpu/e_exp10.S
create mode 100644 sysdeps/i386/fpu/e_exp10.c
delete mode 100644 sysdeps/i386/fpu/e_exp_data.c
delete mode 100644 sysdeps/i386/fpu/e_fmod.S
create mode 100644 sysdeps/i386/fpu/e_fmod.c
delete mode 100644 sysdeps/i386/fpu/e_fmodf.S
create mode 100644 sysdeps/i386/fpu/e_fmodf.c
delete mode 100644 sysdeps/i386/fpu/math_err.c
delete mode 100644 sysdeps/i386/fpu/w_exp10_compat.c
delete mode 100644 sysdeps/i386/fpu/w_fmod_compat.c
delete mode 100644 sysdeps/i386/fpu/w_fmodf_compat.c
--
2.34.1
More information about the Libc-alpha
mailing list