[PATCH 6/8] aarch64/fpu: Add vector variants of sinh

Szabolcs Nagy szabolcs.nagy@arm.com
Thu Mar 21 14:46:54 GMT 2024


The 02/20/2024 16:59, Joe Ramsay wrote:
> ---

OK with one nit below.

Reviewed-by: Szabolcs Nagy <szabolcs.nagy@arm.com>

> Thanks,
> Joe
>  sysdeps/aarch64/fpu/Makefile                  |   1 +
>  sysdeps/aarch64/fpu/Versions                  |  15 ++-
>  sysdeps/aarch64/fpu/advsimd_f32_protos.h      |   1 +
>  sysdeps/aarch64/fpu/bits/math-vector.h        |   8 ++
>  sysdeps/aarch64/fpu/sinh_advsimd.c            | 121 ++++++++++++++++++
>  sysdeps/aarch64/fpu/sinh_sve.c                | 107 ++++++++++++++++
>  sysdeps/aarch64/fpu/sinhf_advsimd.c           |  88 +++++++++++++
>  sysdeps/aarch64/fpu/sinhf_sve.c               |  67 ++++++++++
>  sysdeps/aarch64/fpu/sv_expm1f_inline.h        |  84 ++++++++++++
>  .../fpu/test-double-advsimd-wrappers.c        |   1 +
>  .../aarch64/fpu/test-double-sve-wrappers.c    |   1 +
>  .../aarch64/fpu/test-float-advsimd-wrappers.c |   1 +
>  sysdeps/aarch64/fpu/test-float-sve-wrappers.c |   1 +
>  sysdeps/aarch64/fpu/v_expm1f_inline.h         |  73 +++++++++++
>  sysdeps/aarch64/libm-test-ulps                |   8 ++
>  .../unix/sysv/linux/aarch64/libmvec.abilist   |   5 +
>  16 files changed, 577 insertions(+), 5 deletions(-)
>  create mode 100644 sysdeps/aarch64/fpu/sinh_advsimd.c
>  create mode 100644 sysdeps/aarch64/fpu/sinh_sve.c
>  create mode 100644 sysdeps/aarch64/fpu/sinhf_advsimd.c
>  create mode 100644 sysdeps/aarch64/fpu/sinhf_sve.c
>  create mode 100644 sysdeps/aarch64/fpu/sv_expm1f_inline.h
>  create mode 100644 sysdeps/aarch64/fpu/v_expm1f_inline.h
...
> diff --git a/sysdeps/aarch64/fpu/Versions b/sysdeps/aarch64/fpu/Versions
> index 86c08c1fa3..4774b3efea 100644
> --- a/sysdeps/aarch64/fpu/Versions
> +++ b/sysdeps/aarch64/fpu/Versions
> @@ -89,6 +89,11 @@ libmvec {
>      _ZGVnN4v_asinhf;
>      _ZGVsMxv_asinh;
>      _ZGVsMxv_asinhf;
> +    _ZGVnN2v_atanh;
> +    _ZGVnN2v_atanhf;
> +    _ZGVnN4v_atanhf;
> +    _ZGVsMxv_atanh;
> +    _ZGVsMxv_atanhf;
>      _ZGVnN2v_cosh;
>      _ZGVnN2v_coshf;
>      _ZGVnN4v_coshf;
> @@ -99,10 +104,10 @@ libmvec {
>      _ZGVnN4v_erff;
>      _ZGVsMxv_erf;
>      _ZGVsMxv_erff;
> -    _ZGVnN2v_atanh;
> -    _ZGVnN2v_atanhf;
> -    _ZGVnN4v_atanhf;
> -    _ZGVsMxv_atanh;
> -    _ZGVsMxv_atanhf;

this should be in the previous patch.

> +    _ZGVnN2v_sinh;
> +    _ZGVnN2v_sinhf;
> +    _ZGVnN4v_sinhf;
> +    _ZGVsMxv_sinh;
> +    _ZGVsMxv_sinhf;
>    }
>  }


More information about the Libc-alpha mailing list