[PATCH v2] build-many-glibcs.py: Avoid loading user/system configurations

Arjun Shankar arjun@redhat.com
Mon Mar 18 16:07:50 GMT 2024


> On Mon, 18 Mar 2024 06:31:00 PDT (-0700), arjun@redhat.com wrote:
> >> I have commit verification turned on by default, which trips up pulling
> >> when there is a non-signed commit at HEAD.  There's likely a whole class
> >> of similar configuration issues that could crop up, so this just ignores
> >> user configuration files entirely.
> >>
> >> Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
> >
> > Looks like this unconditionally sets these environment variables? I'm
> > wondering if this limits other use cases like e.g., users who set
> > these environment variables and expect those values to be used during
> > build-many-glibcs (for whatever reason)?
>
> Ya, I was kind of worried about that too.  I've also got a bunch of
> insteadOf lines in my configs, and while I don't know of anything that
> would trip up build-many-glibcs if they disappeared I wouldn't be
> surprised if someone else had a setup that did.  That's why the v1 went
> the other way and just tried to override the signature verification for
> the pulls.
>
> IIRC there's some sort of global git config to override per-repo-path
> settings, maybe the right answer is to just do that for whatever test
> paths I have?

While I don't know about other alternatives, looking at your suggested
patch: will setting/exporting GIT_CONFIG_GLOBAL/GIT_CONFIG_NOSYSTEM
before your build_many_glibcs invocation do the trick for you?



More information about the Libc-alpha mailing list