[PATCH v5] Always define __USE_TIME_BITS64 when 64 bit time_t is used

Adhemerval Zanella Netto adhemerval.zanella@linaro.org
Mon Mar 18 12:18:03 GMT 2024



On 18/03/24 08:58, Florian Weimer wrote:
> * Adhemerval Zanella:
> 
>> diff --git a/sysdeps/generic/features-time64.h b/sysdeps/generic/features-time64.h
>> index 4d38b8ba76..8fe811bd9e 100644
>> --- a/sysdeps/generic/features-time64.h
>> +++ b/sysdeps/generic/features-time64.h
>> @@ -17,3 +17,7 @@
>>     <https://www.gnu.org/licenses/>.  */
>>  
>>  /* The generic configuration only support _TIME_BITS=32.  */
>> +#define __USE_TIME_BITS64       0
>> +
>> +/* The __USE_TIME64_REDIRECTS macro defines whether the 64 time_t
>> +   redirects will be used for 64 bit aware symbols.  */
> 
> I thought that generic was going to be the future in terms of ABIs?  So
> restricting it to _TIME_BITS=32 is surprising.
> 

Right, I added mainly to avoid messing with Hurd default.  But I think
it would be better to add a hurd-only header to override it.


More information about the Libc-alpha mailing list