[PATCH v3 03/32] elf: Remove _dl_sysdep_open_object hook function

Florian Weimer fweimer@redhat.com
Mon Mar 11 18:16:38 GMT 2024


* Joseph Myers:

> On Mon, 11 Mar 2024, Florian Weimer wrote:
>
>> > It's probably helpful also to clearly mark the ones that need a fresh 
>> > review (the ones that I commented on but didn't give a specific "OK" or 
>> > "OK subject to these changes" to).
>> 
>> I thought that the other category was just the rest?  If there is a
>> third category, maybe that's easier to mark for me?
>
> I think there are just two categories: (a) approved (possibly subject to 
> changes) and (b) others (all of which should have either questions or 
> requested changes).  But I also think it's useful to be explicit for each 
> patch which category it's in (rather than just marking (a) with 
> Reviewed-By and having (b) implied by the absence of Reviewed-By).

Thanks for the clarification.  I'm just worried that the markers for (b)
end up in the official commit history, which really wouldn't be ideal.
Is there anything we can add to the commit subject that is already
recognized by the server-side hooks?

Florian



More information about the Libc-alpha mailing list