[PATCH 3/3] elf: Enable TLS descriptor tests on aarch64

Adhemerval Zanella Netto adhemerval.zanella@linaro.org
Mon Mar 11 12:36:28 GMT 2024



On 11/03/24 09:31, Szabolcs Nagy wrote:
> The 02/29/2024 16:46, Adhemerval Zanella wrote:
>> The aarch64 uses a different name than x86 and arm (trad instead
>> os gnu2).  Use it to check whether to enable the TLS descriptor
>> tests.
> 
> aarch64 uses 'trad' for traditional tls and 'desc' for tls
> descriptors, but unlike other targets it defaults to 'desc'.
> 
>>
>> Also rename the internal machinery fron gnu2 to tls descriptors.
>>
>> Checked on aarch64-linux-gnu.
> ...
>> --- a/sysdeps/aarch64/preconfigure
>> +++ b/sysdeps/aarch64/preconfigure
>> @@ -2,5 +2,6 @@ case "$machine" in
>>  aarch64*)
>>  	base_machine=aarch64
>>  	machine=aarch64
>> +	mtls_descriptor=trad
>>  	;;
>>  esac
> 
> i think this is confusing.
> 

It is indeed, it should be 'desc' instead of 'trad' here.

> on aarch64 mtls_descriptor should be 'desc', but we might
> want to run some tests with 'trad' too for coverage (however
> likely different tests than what other targets try to run with
> tlsdesc).
> 

I will check the machinery required to enable all tls tests for
both modes.


More information about the Libc-alpha mailing list