[PATCH] <stdio.h>: Remove comment about getline(3) not being in POSIX

Florian Weimer fweimer@redhat.com
Mon Jun 10 13:17:16 GMT 2024


* Sam James:

> Philip Kaludercic <philipk@posteo.net> writes:
>
>> Sam James <sam@gentoo.org> writes:
>>
>>> Philip Kaludercic <philipk@posteo.net> writes:
>>>
>>>> Sam James <sam@gentoo.org> writes:
>>>>
>>>>> Philip Kaludercic <philipk@posteo.net> writes:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> The current comment stems from 2003[0, 2c008571c3a], and unless I am
>>>>>> missing something should have been removed with the addition of getline
>>>>>> in POSIX.1-2008.
>>>>>
>>>>> Please include this commentary in the commit message.
>>>>
>>>> Sure, here is the updated version:
>>>
>>> Thanks.
>>>
>>>>
>>>> [2. text/x-diff; 0001-stdio.h-Remove-comment-about-getline-3-not-being-in-.patch]
>>>> From 6502738a3df65a6e929d11963ff2c0cd1952f7a3 Mon Sep 17 00:00:00 2001
>>>> From: Philip Kaludercic <philipk@posteo.net>
>>>> Date: Sun, 9 Jun 2024 13:14:59 +0200
>>>> Subject: [PATCH] <stdio.h>: Remove comment about getline(3) not being in POSIX
>>>>
>>>> The comment was written in 2003 (added in 2c008571c3a), predating the
>>>> addition of getline(3) in POSIX.1-2008.
>>>> ---
>>>>  libio/stdio.h | 7 +------
>>>>  1 file changed, 1 insertion(+), 6 deletions(-)
>>>
>>> Reviewed-by: Sam James <sam@gentoo.org>
>>
>> Should I add this to the commit as well? 
>
> If you have a reason to send a new version, yes, if you didn't
> substantially change it. If not, no, and whoever merges (possibly me,
> but let's allow others to comment first) will include any tags like this.

The latest version looks okay to me too.

Thanks,
Florian



More information about the Libc-alpha mailing list