[glibc] LoongArch: Add cfi instructions for _dl_tlsdesc_dynamic

[Andreas K. Huettel]

Am Mittwoch, 17. Juli 2024, 08:50:10 CEST schrieb Florian Weimer:
> * Yinyu Cai via Glibc-cvs:
> 
> > https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=43224b1379d60b1ad98d29ef3d7905d55f828a9f
> >
> > commit 43224b1379d60b1ad98d29ef3d7905d55f828a9f
> > Author: mengqinggang <mengqinggang@loongson.cn>
> > Date:   Fri Jul 5 10:40:33 2024 +0800
> >
> >     LoongArch: Add cfi instructions for _dl_tlsdesc_dynamic
> >     
> >     In _dl_tlsdesc_dynamic, there are three 'addi.d sp, sp, -size'
> >     instructions to allocate stack size for Float/LSX/LASX registers.
> >     Every 'addi.d sp, sp, -size' needs a cfi_adjust_cfa_offset because
> >     of sp is used to compute CFA. But only one 'addi.d sp, sp, -size'
> >     will be run according to HWCAP value. And all cfi_adjust_cfa_offset
> >     will be executed in stack unwinding, it result in incorrect CFA.
> >     
> >     Change _dl_tlsdesc_dynamic to _dl_tlsdesc_dynamic,
> >     _dl_tlsdesc_dynamic_lsx and _dl_tlsdesc_dynamic_lasx.
> >     Conflicting cfi instructions can be distributed to the three functions.
> >     And cfi instructions can correspond to stack down instructions.
> 
> I'm surprised this has been committed during the freeze, and without
> on-list review.

Yeah, unless there's a real good (and urgent) reason for this, let's revert it
for the moment.

> 
> Thanks,
> Florian
> 
> 


-- 
Andreas K. Hüttel
dilfridge@gentoo.org
Gentoo Linux developer 
(council, comrel, toolchain, base-system, perl, libreoffice)
https://wiki.gentoo.org/wiki/User:Dilfridge
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://sourceware.org/pipermail/libc-alpha/attachments/20240717/72d95aa2/attachment.sig>