[PATCH v7] Check global symbols in static library against shared library

Florian Weimer fweimer@redhat.com
Tue Jul 2 09:13:07 GMT 2024


* Joseph Myers:

> On Wed, 29 May 2024, H.J. Lu wrote:
>
>> On Tue, May 28, 2024 at 1:10 PM Joseph Myers <josmyers@redhat.com> wrote:
>> >
>> > On Mon, 27 May 2024, H.J. Lu wrote:
>> >
>> > > Hi Peter, Joseph,
>> > >
>> > > Any comments on this patch?
>> >
>> > I agree with the previous concerns about using nm here (in a way that
>> > requires a new configure check!) instead of aligning the logic with
>> > existing code checking symbol versions and defined symbols.
>> 
>> The new NM feature provides what is needed so that no additional
>> codes are needed.
>
> It needs a new configure check.  And I'm thinking of "additional codes" 
> here primarily in terms of how many different ways are used for extracting 
> symbols from objects - meaning reusing existing code (appropriately 
> refactored as needed to allow multiple places to share it) is strongly 
> preferred to using a different tool in one place.

I agree with Joseph.

I think we can make reuse of the .dynsym files more straightforward if
we apply the columns normalization that's currently in
scripts/abilist.awk:

# Normalize columns.
/^[0-9a-fA-F]+      / { sub(/      /, "  -   ") }

to the .dynsym file upon generation, so that it's possible to use awk
field checks directly.

Thanks,
Florian



More information about the Libc-alpha mailing list