[PATCH] Always define __USE_TIME_BITS64
Adhemerval Zanella Netto
adhemerval.zanella@linaro.org
Wed Jan 17 19:03:26 GMT 2024
On 17/01/24 09:24, Florian Weimer wrote:
> * Adhemerval Zanella:
>
>> diff --git a/io/bits/poll2.h b/io/bits/poll2.h
>> index 6152a8c5e4..c92af1df90 100644
>> --- a/io/bits/poll2.h
>> +++ b/io/bits/poll2.h
>> @@ -43,7 +43,7 @@ poll (struct pollfd *__fds, nfds_t __nfds, int __timeout)
>>
>>
>> #ifdef __USE_GNU
>> -# ifdef __USE_TIME_BITS64
>> +# if __USE_TIME_BITS64 && __TIMESIZE == 32
>> extern int __REDIRECT (__ppoll64_alias, (struct pollfd *__fds, nfds_t __nfds,
>> const struct timespec *__timeout,
>> const __sigset_t *__ss), __ppoll64);
>
> I wonder if it would make sense to introduce a macro
> __USE_TIME64_REDIRECTS and use that in place of __USE_TIME_BITS64. Then
> the bulk of the patch can be a simple textual replacement. I don't
> think it makes sense to replicate that conditional expression across all
> installed headers.
I intended initially to make it explicit, but I think it does make sense
to use a macro here. I will update the patch.
More information about the Libc-alpha
mailing list