[PATCH v12 2/7] linux: Introduce INTERNAL_VSYSCALL

Evan Green evan@rivosinc.com
Mon Feb 26 17:57:23 GMT 2024


On Mon, Feb 26, 2024 at 9:07 AM Florian Weimer <fw@deneb.enyo.de> wrote:
>
> * Evan Green:
>
> > I like it! I'm guessing I should continue to use the
> > INTERNAL_SYSCALL_ERRNO_P() and INTERNAL_SYSCALL_ERRNO(), and you
> > omitted it for example's sake. Will plan to spin with this.
>
> We already hard-code the Linux convention in a few places, e.g.
> sysdeps/unix/sysv/linux/fstatat64.c,
> sysdeps/unix/sysv/linux/clock_gettime.c.  I don't think the macros add
> value here.  We also don't have a macro to inject the error code, I
> believe, so one -ENOSYS will stick around.  But I don't feel strongly
> about it.

Got it, will spin with this as-is then. Thanks for the clarification.
-Evan


More information about the Libc-alpha mailing list