[PATCH] Revert "stdio-common: Exclude bug28 when clang is used"

H.J. Lu hjl.tools@gmail.com
Mon Dec 23 21:28:57 GMT 2024


On Tue, Dec 24, 2024 at 1:05 AM Dmitry Chestnykh <dm.chestnykh@gmail.com> wrote:
>
> This reverts commit 6025b399c735d3d9f27472b11fad2cab4f62aeb5.
>

We need a way to identify that Clang used to test glibc has the bug fix
at configure time.  Otherwise, "make check" with Clang will take too long.
Clang 20 or above have the fix.  Please add such a check for TEST_CC
in configure.ac.

Thanks.

> as issue is fixed in the upstream of llvm-project.
> ---
> https://github.com/llvm/llvm-project/commit/99dddef340e566e9d303010f1219f7d7d6d37a11
> ---
>  stdio-common/Makefile | 11 +----------
>  1 file changed, 1 insertion(+), 10 deletions(-)
>
> diff --git a/stdio-common/Makefile b/stdio-common/Makefile
> index 3f84de3e36..9403fc4b0f 100644
> --- a/stdio-common/Makefile
> +++ b/stdio-common/Makefile
> @@ -200,6 +200,7 @@ tests := \
>    bug25 \
>    bug26 \
>    bug27 \
> +  bug28 \
>    bug29 \
>    errnobug \
>    scanf1 \
> @@ -316,16 +317,6 @@ tests := \
>    xbug \
>    # tests
>
> -# Clang 19 takes a very long time, it ran more than 27 minutes on Intel
> -# Core i7-1195G7 before the process was killed, to compile bug28.c:
> -# https://github.com/llvm/llvm-project/issues/120462
> -# Exclude it when Clang is used for testing.
> -ifneq ($(have-test-clang),yes)
> -tests += \
> -  bug28 \
> -  # tests
> -endif
> -
>  ifeq ($(run-built-tests),yes)
>  ifeq (yes,$(build-shared))
>  ifneq ($(PERL),no)
> --
> 2.47.1
>


-- 
H.J.


More information about the Libc-alpha mailing list