[patch v1 1/1] assert: use internal symbols [BZ #32492] such

H.J. Lu hjl.tools@gmail.com
Sun Dec 22 05:00:06 GMT 2024


On Sun, Dec 22, 2024 at 12:12 PM DJ Delorie <dj@redhat.com> wrote:
>
> "H.J. Lu" <hjl.tools@gmail.com> writes:
> > It also caused:
> >
> > https://sourceware.org/bugzilla/show_bug.cgi?id=32492
>
> How about this?
>
> ---
> Use __writev instead of writev to avoid polluting the external
> namespace.
>
> Resolves: #32492
>
> diff --git a/assert/assert.c b/assert/assert.c
> index a271125f08..3a16f85394 100644
> --- a/assert/assert.c
> +++ b/assert/assert.c
> @@ -117,7 +117,7 @@ __assert_fail_base (const char *fmt, const char *assertion, const char *file,
>           this code path is taken.  */
>        WS ("' failed\n");
>
> -      (void) writev (STDERR_FILENO, v, i);
> +      (void) __writev (STDERR_FILENO, v, i);
>      }
>
>    abort ();
>

OK if it resolves the regression.

LGTM.

Reviewed-by: H.J. Lu <hjl.tools@gmail.com>

Thanks.

-- 
H.J.


More information about the Libc-alpha mailing list