[PATCH v2] x86-64: Exclude test-flt-eval-method-387 for Clang

[H.J. Lu]

On Fri, Dec 20, 2024 at 11:29 AM Sam James <sam@gentoo.org> wrote:
>
> "H.J. Lu" <hjl.tools@gmail.com> writes:
>
> > Since Clang doesn't support -mfpmath=387 on x86-64, on x86-64, exclude
> > test-flt-eval-method-387 for Clang.
> >
> > Signed-off-by: H.J. Lu <hjl.tools@gmail.com>
>
> LGTM

I sent out the v3 patch.

Thanks.

> > ---
> >  sysdeps/i386/fpu/Makefile   | 3 +++
> >  sysdeps/x86/fpu/Makefile    | 1 -
> >  sysdeps/x86_64/fpu/Makefile | 7 +++++++
> >  3 files changed, 10 insertions(+), 1 deletion(-)
> >  create mode 100644 sysdeps/i386/fpu/Makefile
> >
> > diff --git a/sysdeps/i386/fpu/Makefile b/sysdeps/i386/fpu/Makefile
> > new file mode 100644
> > index 0000000000..0973bc8c97
> > --- /dev/null
> > +++ b/sysdeps/i386/fpu/Makefile
> > @@ -0,0 +1,3 @@
> > +ifeq ($(subdir),math)
> > +tests += test-flt-eval-method-387
> > +endif
> > diff --git a/sysdeps/x86/fpu/Makefile b/sysdeps/x86/fpu/Makefile
> > index 705dd9d715..5bba7358c2 100644
> > --- a/sysdeps/x86/fpu/Makefile
> > +++ b/sysdeps/x86/fpu/Makefile
> > @@ -8,7 +8,6 @@ tests += \
> >    test-fenv-sse \
> >    test-fenv-sse-2 \
> >    test-fenv-x87 \
> > -  test-flt-eval-method-387 \
> >    test-flt-eval-method-sse \
> >  # tests
> >  CFLAGS-test-fenv-sse.c += -msse2 -mfpmath=sse
> > diff --git a/sysdeps/x86_64/fpu/Makefile b/sysdeps/x86_64/fpu/Makefile
> > index e39d31c117..b53a62043f 100644
> > --- a/sysdeps/x86_64/fpu/Makefile
> > +++ b/sysdeps/x86_64/fpu/Makefile
> > @@ -1,3 +1,10 @@
> > +ifeq ($(subdir),math)
> > +ifneq ($(have-test-clang),yes)
> > +# NB: Clang doesn't support -mfpmath=387.
> > +tests += test-flt-eval-method-387
> > +endif
> > +endif
> > +
> >  ifeq ($(subdir),mathvec)
> >  libmvec-double-func-list = \
> >    2_core \



-- 
H.J.