[PATCH v2 21/25] math: Use atan2f from CORE-MATH

Adhemerval Zanella Netto adhemerval.zanella@linaro.org
Wed Dec 18 14:17:37 GMT 2024



On 10/12/24 05:32, Paul Zimmermann wrote:
>        Hi DJ,
> 
>>> +  if (__glibc_unlikely (ay == 0))
>>> +    {
>>> +      if (__glibc_unlikely (!(ay | ax)))
>>
>> If ay == 0, this expression is just !ax.  It should be simplified but
>> there's a chance this is a mis-copy from the original and should be
>> checked.
> 
> this was like this in the original, which indeed can be simplified to !ax,
> thanks for your nice review!
> 
> (Adhemerval, see CORE-MATH commit 9b28a4a.)

Ack, I will update it to this commit.


More information about the Libc-alpha mailing list