[PATCH] cet: Pass -mshstk to compiler for tst-cet-legacy-10a[-static].c

Sam James sam@gentoo.org
Tue Dec 17 15:05:01 GMT 2024


"H.J. Lu" <hjl.tools@gmail.com> writes:

> Pass -mshstk to compiler to silence Clang:
>
> In file included from ../sysdeps/x86_64/tst-cet-legacy-10a.c:2:
> ../sysdeps/x86_64/tst-cet-legacy-10.c:29:7: error: always_inline function '_get_ssp' requires target feature 'shstk', but would be inlined into function 'do_test' that is compiled without support for 'shstk'
>    29 |   if (_get_ssp () != 0)
>       |       ^
>
> Signed-off-by: H.J. Lu <hjl.tools@gmail.com>
> ---
>  sysdeps/x86_64/Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sysdeps/x86_64/Makefile b/sysdeps/x86_64/Makefile
> index ce949dba27..9e19cf7e87 100644
> --- a/sysdeps/x86_64/Makefile
> +++ b/sysdeps/x86_64/Makefile
> @@ -354,8 +354,8 @@ CFLAGS-tst-cet-legacy-mod-6c.c += -fcf-protection
>  CFLAGS-tst-cet-legacy-7.c += -fcf-protection=none
>  CFLAGS-tst-cet-legacy-10.c += -mshstk
>  CFLAGS-tst-cet-legacy-10-static.c += -mshstk
> -CFLAGS-tst-cet-legacy-10a.c += -fcf-protection=none
> -CFLAGS-tst-cet-legacy-10a-static.c += -fcf-protection=none
> +CFLAGS-tst-cet-legacy-10a.c += -fcf-protection=none -mshstk
> +CFLAGS-tst-cet-legacy-10a-static.c += -fcf-protection=none -mshstk
>  
>  tst-cet-legacy-4-ENV = GLIBC_TUNABLES=glibc.cpu.hwcaps=SHSTK
>  tst-cet-legacy-6-ENV = GLIBC_TUNABLES=glibc.cpu.hwcaps=SHSTK

OK


More information about the Libc-alpha mailing list