[PATCH] tst-atexit-common.c: Mark _exit_with_flush as noreturn

Sam James sam@gentoo.org
Tue Dec 17 15:04:48 GMT 2024


"H.J. Lu" <hjl.tools@gmail.com> writes:

> Mark _exit_with_flush as noreturn to silence the Clang error on
> tst-atexit-common.c:
>
> In file included from tst-atexit.c:22:
> ../stdlib/tst-atexit-common.c:113:5: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough]
>   113 |     case 0:  /* Child.  */
>       |     ^
> ../stdlib/tst-atexit-common.c:113:5: note: insert 'break;' to avoid fall-through
>   113 |     case 0:  /* Child.  */
>       |     ^
>       |     break;
> 1 error generated.
>
> Signed-off-by: H.J. Lu <hjl.tools@gmail.com>

OK

> ---
>  stdlib/tst-atexit-common.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/stdlib/tst-atexit-common.c b/stdlib/tst-atexit-common.c
> index 4bea464b19..f77ccbbd0d 100644
> --- a/stdlib/tst-atexit-common.c
> +++ b/stdlib/tst-atexit-common.c
> @@ -37,6 +37,7 @@ static char crumbs[sizeof (expected)];
>  static int next_slot = 0;
>  
>  /* Helper: flush stdout and _exit.  */
> +__attribute__ ((__noreturn__))
>  static void
>  _exit_with_flush (int code)
>  {


More information about the Libc-alpha mailing list