[PATCH] tst-unlockedio.c: Explicitly cast double to size_t

H.J. Lu hjl.tools@gmail.com
Mon Dec 16 21:55:24 GMT 2024


Explicitly cast double to size_t to silence Clang error:

tst-unlockedio.c:63:36: error: implicit conversion from 'double' to 'size_t' (aka 'unsigned long') changes value from -0 to 0 [-Werror,-Wliteral-conversion]
   63 |       || fwrite_unlocked (blah, 0, -0.0, fp) != 0
      |          ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~
../libio/bits/stdio.h:189:38: note: expanded from macro 'fwrite_unlocked'
  189 |                      : fwrite_unlocked (ptr, size, n, stream))))
      |                        ~~~~~~~~~~~~~~~             ^

Signed-off-by: H.J. Lu <hjl.tools@gmail.com>
---
 stdio-common/tst-unlockedio.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/stdio-common/tst-unlockedio.c b/stdio-common/tst-unlockedio.c
index 8ff6b074b0..42a03fb7e9 100644
--- a/stdio-common/tst-unlockedio.c
+++ b/stdio-common/tst-unlockedio.c
@@ -56,11 +56,11 @@ do_test (void)
       || f != fp + 1
       || fwrite_unlocked ("", 5.0, 0, --f) != 0
       || f != fp
-      || fwrite_unlocked (cp++, 16, 0.25, fp) != 0
+      || fwrite_unlocked (cp++, 16, (size_t) 0.25, fp) != 0
       || cp != blah + 1
-      || fwrite_unlocked (--cp, 0.25, 16, fp) != 0
+      || fwrite_unlocked (--cp, (size_t) 0.25, 16, fp) != 0
       || cp != blah
-      || fwrite_unlocked (blah, 0, -0.0, fp) != 0
+      || fwrite_unlocked (blah, 0, (size_t) -0.0, fp) != 0
       || ftello (fp) != 0)
     {
       puts ("One of fwrite_unlocked tests failed");
@@ -109,11 +109,11 @@ do_test (void)
       || f != fp + 1
       || fread_unlocked (buf, 5.0, 0, --f) != 0
       || f != fp
-      || fread_unlocked (wp++, 16, 0.25, fp) != 0
+      || fread_unlocked (wp++, 16, (size_t) 0.25, fp) != 0
       || wp != buf + 1
-      || fread_unlocked (--wp, 0.25, 16, fp) != 0
+      || fread_unlocked (--wp, (size_t) 0.25, 16, fp) != 0
       || wp != buf
-      || fread_unlocked (buf, 0, -0.0, fp) != 0
+      || fread_unlocked (buf, 0, (size_t) -0.0, fp) != 0
       || ftello (fp) != 0
       || memcmp (buf, "     ", sizeof (buf)) != 0)
     {
-- 
2.47.1



More information about the Libc-alpha mailing list