[PATCH v4] ungetc: Guarantee single char pushback

[Siddhesh Poyarekar]

On 2024-12-16 05:05, Alejandro Colomar wrote:
> Hi Maciej,
> 
> On Mon, Dec 16, 2024 at 02:52:55AM +0000, Maciej W. Rozycki wrote:
>>>   # else
>>>   #  define FILEBUF_LITERAL(CHAIN, FLAGS, FD, WDP) \
>>>          { _IO_MAGIC+_IO_LINKED+_IO_IS_FILEBUF+FLAGS, \
>>>   	 NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, \
>>> -	 NULL, NULL, (FILE *) CHAIN, FD, \
>>> -	 0, _IO_pos_BAD, 0, 0, { 0 }, &_IO_stdfile_##FD##_lock, _IO_pos_BAD,\
>>> +	 NULL, NULL, (FILE *) CHAIN, FD, 0, { 0 }, \
>>> +	 _IO_pos_BAD, 0, 0, { 0 }, &_IO_stdfile_##FD##_lock, _IO_pos_BAD, \
>>
>>   OK.  New member initialised.
>>
>>   I think it will make sense to keep the line breaks between the same
>> members across all the four FILEBUF_LITERAL definitions so as to make it
>> easier to people to match the variants against each other.
>>
>>   Please coordinate with Alejandro Colomar (CC'd) on cleaning up these
>> definitions, which went out of sync; cf.
>> <https://inbox.sourceware.org/libc-alpha/042e25d3-1b02-c448-1f8c-84f52549f5b5@redhat.com/>.
> 
> Ack.  (I've also checked the other email.)

Do you want to send a patch isolated to this file, which I can rebase on 
top of and push whenever my patch is acked?

Thanks,
Sid