[PATCH] powerpc64le: ROP changes for the dl-trampoline functions

[Peter Bergner]

On 12/11/24 11:08 AM, Joseph Myers wrote:
>> The following patch adds ROP support to our dl-trampoline.S file.
>> The testsuite results (with ROP enabled by the compiler) where clean.
>> Unless anyone sees any issues with the patch, I'll push it fairly soon.
> 
> This seems to have broken the build for powerpc64-linux-gnu (big-endian) 
> in build-many-glibcs.py.  I'm seeing errors of the form:
> 
> /notnfs/josmyers/glibc-bot/install/compilers/powerpc64-linux-gnu/lib/gcc/powerpc64-glibc-linux-gnu/13.3.1/../../../../powerpc64-glibc-linux-gnu/bin/ld: /notnfs/josmyers/glibc-bot/build/glibcs/powerpc64-linux-gnu/glibc/elf/librtld.os: in function `.LY_dl_runtime_resolve':
> /notnfs/josmyers/glibc-bot/src/glibc/elf/../sysdeps/powerpc/powerpc64/dl-trampoline.S:38:(.text+0x25c52): undefined reference to `FRAME_ROP_SAVE'
> 
> (Note that INT_PARMS is now defined to refer to FRAME_ROP_SAVE 
> unconditionally, without regard to whether __ROP_PROTECT__ is defined.)

I'll have a look.  Thanks for pointing that out.

Peter