[PATCH v6] Add TEST_CC and TEST_CXX support

Sam James sam@gentoo.org
Wed Dec 11 07:02:10 GMT 2024


"H.J. Lu" <hjl.tools@gmail.com> writes:

> On Wed, Dec 11, 2024 at 2:17 PM H.J. Lu <hjl.tools@gmail.com> wrote:
>>
>> Changes in v6:
>>
>> 1.  Add LIBC_TRY_CC_AND_TEST_CC_OPTION, LIBC_TRY_CC_AND_TEST_CC_COMMAND
>> and LIBC_TRY_CC_AND_TEST_LINK to test both CC and TEST_CC.
>> 2.  Restore CC after libc_cv_test_x86_have_amx_tile.
>>
>>
>> Support testing glibc build with a different C compiler or a different
>> C++ compiler with
>>
>> $ ../glibc-VERSION/configure TEST_CC="gcc-6.4.1" TEST_CXX="g++-6.4.1"
>>
>> 1. Add LIBC_TRY_CC_AND_TEST_CC_OPTION, LIBC_TRY_CC_AND_TEST_CC_COMMAND
>> and LIBC_TRY_CC_AND_TEST_LINK to test both CC and TEST_CC.
>> 2. Add check and xcheck targets to Makefile.in and override build compiler
>> options with ones from TEST_CC and TEST_CXX.
>>
>> Tested on Fedora 41/x86-64:
>>
>> 1. Building with GCC 14.2.1 and testing with GCC 6.4.1 and GCC 11.2.1.
>> 2. Building with GCC 15 and testing with GCC 6.4.1.
>>
>> Support for GCC versions older than GCC 6.2 may need to change the test
>> sources.  Other targets may need to update configure.ac under sysdeps and
>> modify Makefile.in to override target build compiler options.
>>
>> Signed-off-by: H.J. Lu <hjl.tools@gmail.com>
>>
>>
>> H.J.
>
> Oops.  The patch was missing.
>
> H.J.

Why not LIBC_TRY_CC_AND_TEST_CC_COMMAND for the tile check?

The patch LGTM otherwise:

Reviewed-by: Sam James <sam@gentoo.org>

>
> [2. text/x-patch; v6-0001-Add-TEST_CC-and-TEST_CXX-support.patch]...


More information about the Libc-alpha mailing list