[PATCH v2 11/25] math: Fix spurious-divbyzero flag name

DJ Delorie dj@redhat.com
Sat Dec 7 02:36:36 GMT 2024


Adhemerval Zanella <adhemerval.zanella@linaro.org> writes:
> diff --git a/math/gen-libm-test.py b/math/gen-libm-test.py
> @@ -103,7 +103,7 @@ EXC_EXPECTED = {'divbyzero': 'DIVBYZERO_EXCEPTION',

Er, what about the above?  DIVBYZERO_EXCEPTION  Doesn't occur in the
source tree either, but DIVBYZERO_EXC does.

The below is LGTM though.
Reviewed-by: DJ Delorie <dj@redhat.com>

>                  'invalid': 'INVALID_EXCEPTION',
>                  'overflow': 'OVERFLOW_EXCEPTION',
>                  'underflow': 'UNDERFLOW_EXCEPTION'}
> -EXC_OK = {'divbyzero': 'DIVBYZERO_EXCEPTION_OK',

This string doesn't exist in the source tree, except here...

> +EXC_OK = {'divbyzero': 'DIVIDE_BY_ZERO_EXCEPTION_OK',

This string occurs often, so ok.

>            'inexact': '0',
>            'invalid': 'INVALID_EXCEPTION_OK',
>            'overflow': 'OVERFLOW_EXCEPTION_OK',



More information about the Libc-alpha mailing list