[PATCH] Raise the minimum GCC version to GCC 7.1 [BZ #32414]

Stefan Liebler stli@linux.ibm.com
Thu Dec 5 10:08:03 GMT 2024


On 04.12.24 23:25, Sam James wrote:
> "H.J. Lu" <hjl.tools@gmail.com> writes:
> 
>> commit 776938e8b8dcf2b59998979e91cc0f9db7d771a8
>> Author: Joseph Myers <josmyers@redhat.com>
>> Date:   Wed Dec 4 20:04:04 2024 +0000
>>
>>     Implement C23 sinpi
>>
>> doesn't build with GCC 6:
>> ...
>> ./s_cospi_template.c: In function ‘__cospif128’:
>> ./s_cospi_template.c:29:27: error: invalid suffix "f128" on floating constant
>>    x = M_FABS (x - M_MLIT (2.0) * M_SUF (round) (M_LIT (0.5) * x));
>>                            ^
>> ../sysdeps/generic/math-type-macros-float128.h:31:19: note: in
>> definition of macro ‘M_MLIT’
>>  #define M_MLIT(c) c ## f128
>>                    ^
>>
>> Also tst-strtod5.c and tst-strtod5i.c can't build with GCC 6.  Raise the
>> minimum GCC version to GCC 7.1.  This fixes BZ #32414.
> 
> In the patch, the version is inconsistent. Please change it to 7.1 in
> both instances.

And please also adjust the configure-check:
https://sourceware.org/git/?p=glibc.git;a=blob;f=configure.ac;h=895bd5267d222a34453f528e3fba6cebfdbb7ef6;hb=HEAD#l565

If you raise the minimum GCC to 7.1, you can at least remove the s390x
specific confiugre-check.
https://sourceware.org/git/?p=glibc.git;a=blob;f=sysdeps/s390/configure.ac;h=89c3e5b2115d12d8d5d104ae9a121be40c47d242;hb=HEAD#l179

I have not checked if other archs have similar configure-checks.

Bye,
Stefan


More information about the Libc-alpha mailing list