[PATCH v2] Remove unused dl-procinfo.h

[Adhemerval Zanella Netto]

On 04/12/24 11:00, Stefan Liebler wrote:
> On 29.11.24 18:22, Wilco Dijkstra wrote:
>> Hi Stefan,
>>
>>> For s390, we've discussed it internally and we are fine with removing
>>> the names. Thus if you do so, as already mentioned please also remove
>>> dl_s390_cap_flags in sysdeps/s390/dl-procinfo-s390.c and the
>>> _DL_HWCAP_COUNT definition.
>>
>> I've done that and also removed the duplicated HWCAP definitions in
>> sysdeps/s390/dl-procinfo.h (which allows its removal after adding a few
>> includes of sys/auxv.h - overall this seems better, but please check that's
>> fine). It passes buildmanyglibc.
>>
> Thanks a lot. Yes, the s390 part is fine. It also builds fine on my side.
> 
> Do you know why the hex-values for AT_HWCAP2-4 are prefixed with "0x",
> but not AT_HWCAP?

I think it is most likely an overlook.

> Shall we also prefix it?

Yeap;

> diff --git a/sysdeps/unix/sysv/linux/dl-sysdep.c
> b/sysdeps/unix/sysv/linux/dl-sysdep.c
> index d1170a1d00..1dfd4ff460 100644
> --- a/sysdeps/unix/sysv/linux/dl-sysdep.c
> +++ b/sysdeps/unix/sysv/linux/dl-sysdep.c
> @@ -185,7 +185,7 @@ _dl_show_auxv (void)
>           [AT_GID - 2] =                { "GID:               ", dec },
>           [AT_EGID - 2] =               { "EGID:              ", dec },
>           [AT_PLATFORM - 2] =           { "PLATFORM:          ", str },
> -         [AT_HWCAP - 2] =              { "HWCAP:             ", hex },
> +         [AT_HWCAP - 2] =              { "HWCAP:             0x", hex },
>           [AT_CLKTCK - 2] =             { "CLKTCK:            ", dec },
>           [AT_FPUCW - 2] =              { "FPUCW:             ", hex },
>           [AT_DCACHEBSIZE - 2] =        { "DCACHEBSIZE:       0x", hex },
> 
> 
> Bye,
> Stefan
> 
>> Cheers,
>> Wilco
>>
>>
>> v2: Remove s390 dl-procinfo.h.
>>
>> Remove unused _dl_hwcap_string defines.  As a result many dl-procinfo.h headers
>> can be removed.  This also removes target specific _dl_procinfo implementations
>> which only printed HWCAP strings using dl_hwcap_string.
>>
>> Passes buildmanyglibc, OK for commit?
>>
>> ---
>>