[PATCH v2] nss: Get rid of alloca usage in db-XXX

Joe Simmons-Talbott josimmon@redhat.com
Thu Sep 28 13:15:13 GMT 2023


On Thu, Sep 28, 2023 at 01:19:30PM +0200, Andreas Schwab wrote:
> On Sep 27 2023, Joe Simmons-Talbott wrote:
> 
> > @@ -160,7 +163,14 @@ enum nss_status								      \
> >    else									      \
> >      {									      \
> >        const size_t size = (keysize) + 1;				      \
> > -      key = alloca (size);						      \
> > +      if (!scratch_buffer_set_array_size (&sbuf, 1, size))		      \
> > +	{								      \
> > +	  *errnop = ENOMEM;						      \
> 
> One more change: this should be errno, not ENOMEM.

Thanks for the review.  I've posted a v3 with both changes.

Thanks,
Joe



More information about the Libc-alpha mailing list