[PATCH] AArch64: Add support for MOPS memcpy/memmove/memset

Wilco Dijkstra Wilco.Dijkstra@arm.com
Mon Oct 23 12:35:13 GMT 2023


Hi,

>> It's unclear to me what all these magic defines do... So you're saying all
>> of the internal implementations should use .hidden instead of one of the
>> [libc_]hidden_[builtin_]def macros? Ie. they should not be used inside
>> the multiarch directory at all?
>
> we don't need .hidden: all symbols are hidden in libc.so unless
> the Versions files export the symbol explicitly (and for static
> linking we don't really care about hidden).

OK, I'll remove these defines in the next version then.

> i think we should just drop these macros in the multiarch asm.
> (and fix things up e.g. if asm code is directly included across
> multiarch and generic code such that only generic exported syms
> get the alias)

I'll do a quick cleanup of the existing multiarch directory in a seperate
patch. There are many unnecessary differences between the various
implementations.

Cheers,
Wilco


More information about the Libc-alpha mailing list