[PATCH v2] Skip mcount overflow and tunables tests on "--disable-tunables"

Rajalakshmi Srinivasaraghavan rajis@linux.vnet.ibm.com
Wed Mar 22 12:56:36 GMT 2023


On 3/22/23 6:29 AM, Siddhesh Poyarekar wrote:
> On 2023-03-21 14:33, MAHESH BODAPATI via Libc-alpha wrote:
>> From: Mahesh Bodapati <mahesh.bodapati@ibm.com>
>>
>> Add a have_tunables check on the new tests added in recent commit
>> - "gmon: improve mcount overflow handling [BZ# 27576]"
>> commit ID  31be941e4367c001b2009308839db5c67bf9dcbc
>
> Orthogonal question since you posted this patch to fix a 
> --disable-tunables build: are you actually using this configuration or 
> is it just part of your testing matrix?  We are considering removing 
> the ability to disable tunables[1] so if the option is important to 
> you, you should chime in there.

Mahesh submitted this patch a few days before Adhemerval submitted the 
patch removing the ability to disable tunables.  We have a power CI 
which tests disable-tunable option and that was the reason for fixing 
this. If we are going to remove that ability, I am fine with discarding 
this patch.

>
> Thanks,
> Sid
>
> [1] https://sourceware.org/pipermail/libc-alpha/2023-March/146320.html


More information about the Libc-alpha mailing list