[PATCH] aarch64: Standardized codes by using macro __glibc_{un,}likely and AARCH64_R

Szabolcs Nagy szabolcs.nagy@arm.com
Mon Mar 13 09:07:01 GMT 2023


The 03/13/2023 11:18, caiyinyu wrote:
> ---
>  sysdeps/aarch64/dl-machine.h | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/sysdeps/aarch64/dl-machine.h b/sysdeps/aarch64/dl-machine.h
> index 4170b9269f..da4f08dec6 100644
> --- a/sysdeps/aarch64/dl-machine.h
> +++ b/sysdeps/aarch64/dl-machine.h
> @@ -83,7 +83,7 @@ elf_machine_runtime_setup (struct link_map *l, struct r_scope_elem *scope[],
>  	 to intercept the calls to collect information.  In this case we
>  	 don't store the address in the GOT so that all future calls also
>  	 end in this function.  */
> -      if ( profile)
> +      if (__glibc_unlikely (profile))
>  	{

profile is unlikely, but this check only runs once
so i don't think this is useful.

the rest looks ok... but is there a reason to clean
this up now? there are many __builtin_expect in the
codebase and fixing them likely makes backporting
patches harder without much benefit.



More information about the Libc-alpha mailing list