[PATCH] Remap __GLIBC_FLT_EVAL_METHOD to 0 if __FLT_EVAL_METHOD__ is -1

Wilco Dijkstra Wilco.Dijkstra@arm.com
Thu Mar 9 19:37:57 GMT 2023


Hi Kito,

This comment reads a bit strange after the change:

> >  /* In the default version of this header, follow __FLT_EVAL_METHOD__.
> > -   -1 is mapped to 2 (considering evaluation as long double to be a
> > +   -1 is mapped to 0 (considering evaluation as same precision to be a
> >     conservatively safe assumption), and if __FLT_EVAL_METHOD__ is not
> >     defined then assume there is no excess precision and use the value
> >     0.  */

Maybe this would be clearer?

In the default version of this header, follow __FLT_EVAL_METHOD__.
If __FLT_EVAL_METHOD__ is not defined or set to -1, assume there is no
excess precision and use the value 0 (this is correct for most targets).


Also separating the commit message from the rest of the discussion would be
good - I assume the quote from the C99 standard is not part of it?

Cheers,
Wilco


More information about the Libc-alpha mailing list