[PATCH] hurd: fix build of tst-system.c

Adhemerval Zanella Netto adhemerval.zanella@linaro.org
Wed Mar 8 11:48:49 GMT 2023



On 08/03/23 05:11, Adam Yi wrote:
> We made tst-system.c depend on pthread, but that requires linking with
> $(shared-thread-library). It does not fail under Linux because the
> variable expands to nothing under Linux, but it fails for Hurd.
> 
> I tested verified via cross-compiling that "make check" now works
> for Hurd.
> 
> Signed-off-by: Adam Yi <ayi@janestreet.com>

LGTM, thanks.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>

> ---
>  stdlib/Makefile | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/stdlib/Makefile b/stdlib/Makefile
> index cd32f53b56..5e38f0e6a2 100644
> --- a/stdlib/Makefile
> +++ b/stdlib/Makefile
> @@ -281,6 +281,7 @@ LDLIBS-test-on_exit-race = $(shared-thread-library)
>  LDLIBS-tst-canon-bz26341 = $(shared-thread-library)
>  LDLIBS-tst-arc4random-fork = $(shared-thread-library)
>  LDLIBS-tst-arc4random-thread = $(shared-thread-library)
> +LDLIBS-tst-system = $(shared-thread-library)
>  
>  LDLIBS-test-dlclose-exit-race = $(shared-thread-library)
>  LDFLAGS-test-dlclose-exit-race = $(LDFLAGS-rdynamic)


More information about the Libc-alpha mailing list